Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAO Meteorology Equations #168

Merged
merged 11 commits into from
Jan 21, 2025
Merged

FAO Meteorology Equations #168

merged 11 commits into from
Jan 21, 2025

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Jan 6, 2025 •
edited
Loading

PR Summary

Add meteorology equations from the Food and Agriculture Organization (FAO) Irrigation and Drainage Paper 56 and Dutton's Ceaseless Wind

Related Tickets & Documents

Closes #166

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • Clear Outputs

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Meowdy! See your PR preview:
🔍 Git commit SHA: 1bb1a47
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/168

@cyschneck cyschneck self-assigned this Jan 10, 2025
@cyschneck cyschneck marked this pull request as ready for review January 14, 2025 20:35
@cyschneck cyschneck added the documentation Improvements or additions to documentation label Jan 14, 2025
anissa111
anissa111 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the equations look great and are rendering on the preview, thanks for doing this!

kafitzgerald
kafitzgerald approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cyschneck cyschneck merged commit bcd330b into NCAR:main Jan 21, 2025
3 checks passed
@cyschneck cyschneck deleted the fao_meteorology_eq branch January 21, 2025 19:22
github-actions bot pushed a commit that referenced this pull request Jan 21, 2025
@cyschneck @github-actions
Delete preview for pull request #168
389133d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kafitzgerald kafitzgerald kafitzgerald approved these changes

@anissa111 anissa111 anissa111 approved these changes

@jukent jukent Awaiting requested review from jukent

Assignees

@cyschneck cyschneck

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Meteorology equations in NCL entry
3 participants
@cyschneck @kafitzgerald @anissa111